gomod: Update dependencies #186
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stéphane Graber <[email protected]>
The Github Actions runners have some weird issues with nested virtualization. Signed-off-by: Stéphane Graber <[email protected]>
breml
reviewed
Dec 16, 2024
| @@ -556,7 +556,10 @@ func TestAccInstance_fileUploadContent_VM(t *testing.T) { | |||
| instanceName := petname.Generate(2, "-") | |||
|
|
|||
| resource.Test(t, resource.TestCase{ | |||
| PreCheck: func() { acctest.PreCheck(t) }, | |||
| PreCheck: func() { | |||
There was a problem hiding this comment.
@stgraber in #169 , it is consistently failing on 3 more tests, see: https://github.com/lxc/terraform-provider-incus/actions/runs/12346795339/job/34452893067?pr=169#step:8:165
TestAccInstance_virtualMachineTestAccInstance_virtualMachineNoDevIncusTestAccInstance_restartVirtualMachine
There was a problem hiding this comment.
Yes, but those tests already have the correct PreCheck, the precheck is just missing the github actions detection part.
There was a problem hiding this comment.
Why are these tests suddenly starting to fail?
There was a problem hiding this comment.
Github changed the type of VMs they're using to run Github Actions.
maveonair
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.